Interpolate between two scenarios #1685
Conversation
aaccensi
force-pushed
the
scenario-interpolation
branch
from
8fe07d1 to
654db5d
Compare
noracato
left a comment
noracato
left a comment
There was a problem hiding this comment.
Nice work! Especially on the specs! Thank you for adding the extra spec for the API as well.
It works well as an extension of the existing code. I do think we can win some space by replacing the now many validators by introducing simple Dry validation rules. @louispt1 has been working with them a lot lately, he should be able to help you out.
Again well done!
louispt1
left a comment
louispt1
left a comment
There was a problem hiding this comment.
Apart from the one remark below and the spec for the batch endpoint I'd say it's looking good!
noracato
left a comment
noracato
left a comment
There was a problem hiding this comment.
The implementation of Dry and the rulesets went well. Thanks for trying it out!
There are a few optimizations to be made regarding Rails. You can check my comments in the code. If you need any more explanations or resources, please ask!
aaccensi
force-pushed
the
scenario-interpolation
branch
from
7ac3dae to
027abdb
Compare
References #1684
Description
Adds the capability to interpolate between two scenarios with the API endpoint:
POST /api/v3/scenarios/interpolateNow if we pass a
start_scenario_idbesides the mandatoryend_yearit will interpolate using the values of the given start scenario instead of the starting values of the scenario targeted by the endpoint.Type of change
Checklist
Related Issues
Closes #1684